Re: [PATCH] xen/sched: fix stale schedule.c references in comments

[Furkan Çalışkan <frn1furkan10@xxxxxxxxx>]

On 6/1/26 14:12, Andrew Cooper wrote:
> On 01/06/2026 6:30 am, Furkan Caliskan wrote:
>> diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
>> index 07656a57e9..fbcdc53f7b 100644
>> --- a/xen/common/sched/credit.c
>> +++ b/xen/common/sched/credit.c
>> @@ -873,7 +873,7 @@ csched_res_pick(const struct scheduler *ops, const 
>> struct sched_unit *unit)
>>      struct csched_unit *svc = CSCHED_UNIT(unit);
>>  
>>      /*
>> -     * We have been called by vcpu_migrate() (in schedule.c), as part
>> +     * We have been called by vcpu_migrate() (in core.c), as part
> 
> As you've found, file references get stale, but so do function
> references.  vcpu_migrate() ceased existing in 9a36de177c1
> "xen/schedule: Fix races in vcpu migration" in 2018.
> 
> These comments want adjusting rather more.  In this case:
> 
> diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
> index 07656a57e979..5ee26cde58f6 100644
> --- a/xen/common/sched/credit.c
> +++ b/xen/common/sched/credit.c
> @@ -873,11 +873,12 @@ csched_res_pick(const struct scheduler *ops, const
> struct sched_unit *unit)
>      struct csched_unit *svc = CSCHED_UNIT(unit);
>  
>      /*
> -     * We have been called by vcpu_migrate() (in schedule.c), as part
> -     * of the process of seeing if vc can be migrated to another pcpu.
> +     * We have been called, as part of the process of seeing if vc can be
> +     * migrated to another pcpu.
> +     *
>       * We make a note about this in svc->flags so that later, in
> -     * csched_unit_wake() (still called from vcpu_migrate()) we won't
> -     * get boosted, which we don't deserve as we are "only" migrating.
> +     * csched_unit_wake() we won't get boosted, which we don't deserve
> as we
> +     * are "only" migrating.
>       */
>      set_bit(CSCHED_FLAG_UNIT_MIGRATING, &svc->flags);
>      return get_sched_res(_csched_cpu_pick(ops, unit, true));
> 
> 
> still has all the salient information but is rather less likely to get
> stale.
> 
> ~Andrew

Thanks for the feedback Andrew. I only checked for stale file references 
and missed the stale function references. I will fix it, and send a v2.