Re: [PATCH for-4.22] xen/efi: Use blexit() instead of BUG_ON() in read_file()

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 6/2/26 3:10 PM, Andrew Cooper wrote:
> On 02/06/2026 1:34 pm, Jan Beulich wrote:
> > On 02.06.2026 14:24, Szymon Acedański wrote:
> > > Follow-up to 880e40b187aa ("xen/efi: Fix boot from a device without
> > > a file system"), which added a BUG_ON() guard in read_file().
> > >
> > > But as Jan pointed out, before ExitBootServices BUG_ON()
> > > is not functional. It results in a hang with no message.
> > >
> > > On the other hand blexit() prints a message and returns back
> > > to the bootloader.
> > >
> > > Link: 
> > > https://lore.kernel.org/xen-devel/bb0f007e-697e-4501-97ea-3b59cf494ec6@xxxxxxxx/T/#m4725c8cbc0946a5533aea03fc240267ef139648d
> > While Linux uses Link:, as per sending-patches.pandoc we don't. It wants
> > to be Reported-by: instead, and there wants to be a Fixes: tag.
> >
> > > Signed-off-by: Szymon Acedański <accek@xxxxxxxxxxxxxxxxxxxxxx>
> > With the above properly sorted:
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> CC Oleksi.  We're past RC1 now, so everything needs release acks.
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks.

~ Oleksii