[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.22 1/5] tools/bitops: adjust bitmap_or() interface to match hypervisor
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 3 Jun 2026 21:03:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SalFx0HE0KXFJI8Hh84m0f5kI0bFpmmWHZ6RrIYJKis=; b=ukjzPHz9hRMPtNz3ZEqSkTrwGH2hTUdp+rDyiiKSchUFX84YsWj9zD0XTEL4bgig6ZgESCNKGd2D9+ezN7cinpelO773G7NJIZXBRDczhmUoyJI1jbbGrPLp+2Sm6t6dpOGVwn9JDJo8hgOsE3KjX9LH2j5tufYB4WcV56G0Tjhni9XeAybnOTU4+y7bLU9fhkl/H8D+Cch5AM5zYWYa2SsqANMzZ0guw7dCdMOUbYzXJP9fLOFCGb64VLrv9Qv8HTxVSYDUF0QVOerCxTiv996fk9nWdntOUlc3TqEDtG2NfPgkP/H2e510InVsj7sKD4VFj6bEu1LWxpbDV+HJ4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ifWlxIOAQm/dL2htjRvCDVfpsM68I0y2AOtnBESquI0u9QwIsTFk5cUnI8VJUtpL0dlmOc7le2j8R0vjF+aguperZs2THe7v3jT/auAs4rtep60M+tAmdBk7wa4r7AK1J1nKMZZKgM1/3occjK1lz9cY/q8zjq+WcpKENMRvlgyNjSqXPzag5WsHQdkO9CYMVo6aRWwOITgUfFL5hnempJO4rXbMWL4vVk8kLu8wwstAUYV2l/nDJYX2Rdm2jIYmPgMyKK2+X00dzUAaTksEDuYAI9dNCj4DIMJZj8l0yn6LBPKT6VJqaF8pbQygO7qP6DdeV1KXF8LcFD7bEXzLlw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 03 Jun 2026 19:03:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 03, 2026 at 04:34:32PM +0200, Anthony PERARD wrote:
> On Mon, Jun 01, 2026 at 05:43:28PM +0200, Roger Pau Monne wrote:
> > Adjust the only toolstack caller to use the new interface. No functional
> > change intended.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks.
> > ---
> > I'm tempted to rewrite bitmap_or() to use unsigned long (just like the
> > hypervisor side), but that's outside the scope of this change.
>
> You mean revert 11d0044a1689 ("tools/libxc: Modify bitmap operations to
> take void pointers") ? Or maybe the hypervisor code when trough the same
> path.
Kind of yes, so that it matches more closely the hypervisor interface.
Anyway, not going to do that now either.
Regards, Roger.
|
