Re: [PATCH 02/17] libacpi: new DSDT ACPI table for Q35

[Thierry Escande <thierry.escande@xxxxxxxxxx>]

On 6/12/26 15:24, Roger Pau Monné wrote:
> On Fri, Jun 12, 2026 at 12:01:00PM +0200, Thierry Escande wrote:
>>
>> On 4/28/26 12:17, Roger Pau Monné wrote:
>>
>> Well, the iasl compiler doesn't support the defined() directive (at
>> least the latest Debian version from 2025) so I'll rather use something
>> like:
>>
>> #define MACHINE_TYPE MACHINE_TYPE_XXX
>>
>> #if MACHINE_TYPE == MACHINE_TYPE_XXX
>>  ...
>> #elif MACHINE_TYPE == MACHINE_TYPE_YYY
>>  ...
>> #endif
> 
> Oh, I see, I wasn't aware of it not supporting defined() when #ifdef
> is available.  Kind of weird to support one but not the other.
> 

And there's more fun: The iasl compiler complains about multiline
comments when enclosed within #if #endif directives. Sometimes it's a
warning about nested comments, sometimes it produces errors.

Regards,



--
Thierry Escande | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech