[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.22 v2.5] xen/arm: gic: defer host LPI allocation until after ITS init


  • To: Julien Grall <julien@xxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Fri, 19 Jun 2026 13:34:48 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h1NfvivOeZBUAcQf+iWE0oAvyh/PnP70ZvKIn80R0m4=; b=jRV+63DV3+UK9tGOqMXNtBhqNxe0N4LGMcPLxs/tFWP5u+zhOeZritee/y1DgqrR8LQz0oilXXpgkGNUZVLVO4z92IgzxyS+vZpKkG8ImY15jfDzVxzyRFgrrZOe2Fr/8TWpf2GTdDwveGbV+3AH2+aNdjqkLu//TfhFaLwmvlICui/pwjJkvDSPNybXchsIy27yDqeKiG1Og2zxsrsrZXX/DSMnHKajXsFvHsDwIq4zrKYqCHBAIX4BhvY4nlawXaWZeON/RFDRnHUdByJdo3jVs24RKnQp6TYYKxuEFywU2SxYDDJzjh1FNB/TIqRKlKBvfoDYC6X7/ViFVRzrLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gE11j1TZAp3I9frvAXc4Oo6PPcT6F8keI6SMEA5Og9D7dI5e9T/6xdSDBFKp152Ml5lG0Pn5X+Tb0SH9hu+nFvxJEeS7P2457xz7SHFlSIki6VYrTxXF14cwZhID2b6P4TOO3ZVbLlhH1YR69vPQtRy0gRllZH84BVBF/gleHzDnEtLhX4k/4SdTDc5NGBY0b03jbDT/ebxjdB0pGZLzQNPmhlffKMpN9LwaASqOWrzHr7Kui430gUeANWC7nhZ8B/jqoCs09o/tbrDkJ2U3mB1/HhzcVSptNULSDREAHfW1oJeu/zUn+JXMnyrDNwgm9Azva+IyfkqMjUgjymm+JA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Mykola Kvach <xakep.amatop@xxxxxxxxx>, "Oleksandr Tyshchenko" <oleksandr_tyshchenko@xxxxxxxx>
  • Delivery-date: Fri, 19 Jun 2026 11:35:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 19-Jun-26 13:23, Julien Grall wrote:
> Hi Michal,
> 
> On 19/06/2026 10:48, Orzel, Michal wrote:
>> @Oleksii, can we ask for a release ack here?
> 
> Can you explain the pros/cons of introducing this patch quite late?
The advantage is that it fixes the broken LPIs on affected hardware.
The disadvantage is the reordering risk but I don't think there is any issue.

> 
> One of the risk here is that we are now initializing the LPIs *after* 
> the ITSes. I understand this is because we want to know the workaround. 
> However, I vaguely recall that there was a dependency in the 
> configuration. So are we confident the new ordering will not bring other 
> issues? Ideally this should have been explained in the commit message.
gic-v3-its.c never references host LPI state, so ITS init has no dependency on 
LPIs.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.