[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/23] xen/arm: smmuv3: Add support for stage-1 and nested stage translation


  • To: Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • From: Milan Djokic <milan_djokic@xxxxxxxx>
  • Date: Fri, 19 Jun 2026 15:55:14 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LBSWRKaLFCzGUeJ9D0+Lmm6mvf3tEba5Qmp2iggzkXc=; b=Fzkj6cOcXSNjkT+ziFe2vzl43DkNXzhh9JmykCXUlJD42p5pnphj1DO+22ep34/LwpKsAdc1CllTjFq6T5XM0kViXN3+xlYcxJqHL+pSwI1uMjjsUGkrqGMNUTX6gDfLISrguHo8RFVH1p9anzhC78gw0R4nKpahehkbhl0ubpn0ve1zjDxbmp1wP/K2t/ptPGq69IKVINLGq2toy/eZOURl8v8BgSfptcores77nXsoaz3dWw0TC6FxNtaFbC8pQpVk1wHhL102ixGsxs1xgppODMUNeW2AhPxxJCTdtKxtVhg4MyWXeSFu++0XwQBCeo7S23AJliP3dZdmHcHlaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nmbWsSwzMZlaveeSss2f/uUvoUxlOzn2QpU7PTWkV3d8fvazfPaS2EgUG1V5aQCZztLHJqY59HKAIVYfznrnvLtzPvYlV1dY6AW77/zUge8wgi9RI5MV1Ux/WPlx74UUH+MZHvVlqs45VL7cfsnymfJUxDFb2q21/I44FYbQvmyoNs0JM8XqQoNKXOg72btNuYpmPWXnKAmbmJliz6458sObwpJalW9ilzFoOr5JZa7nZPdt2dzF/dun//IBE1CabFg8FuqJzavA6D/2V08zOtKqzc/0Q4HS3QgQI/frsqG1MMmlwQvfYjFGiPhr8a5bxlhCoZHN7Gqdx26TZI+H1A==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 19 Jun 2026 13:55:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Julien, Bertrand,

On 6/16/26 21:45, Julien Grall wrote:
Hi Bertrand,

On 11/06/2026 07:12, Bertrand Marquis wrote:
This primarily targets systems where the SMMU does not support Stage-2 
translation.
If we decide to keep this code, I will address the associated security considerations and 
document the corresponding AoU in the design. Otherwise, we can fall back to supporting 
only the "nested" translation case.

Thanks for the feedback. I think for such setup, I would consider whether we 
can use the stage-1 in Xen to protect the device. AFAIK, this what Linux will 
do.

I would be interested to hear what the other maintainers think.

Giving access to the smmu to a guest means giving it a solution to access 
whatever he wants through a DMA engine.
This is not less secure than no SMMU at all but I would definitely think that 
in such a case SMMU should be reserved for
Xen to use it to protect from accessing other guests memory using DMA.

Now i know that in some setups there are cases where a specific device cannot 
be used without an SMMU (mostly GPUs
but there might be others). In that case, the device cannot be used easily if 
the kernel cannot use the SMMU to remap the
memory at a convenient place for the device.

We should not disallow such cases completely but we should give strong 
recommandations when such a setup is used.

Thanks for the feedback! I think before allowing S1 without S2 we need
to make sure it works and I am not convinced this is the case today.

Cheers,


Thank you for your feedback.
There are some existing issues previously pointed out by Luca for the stage-1-only mode. I will apply fixes and make sure that this works
correctly in the next version of the patch series.
I will also address the associated security considerations in the design.

BR,
Milan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.