Re: [RFC PATCH v4 3/6] libxl: Add libxl__device_pci_get_qapi_json() internal API

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Apr 23, 2026 at 04:50:28PM +0200, Thierry Escande wrote:
> This function generates the qapi json object for a PCI device to be
> passthrough'd to a guest.
> 
> With the new option hotplug=0 for PCI passthrough, device parameters
> will be passed using Qemu -device command line option. Since -device
> accepts qapi json string, this new function will be used to do so.

Here, instead of speaking about "hotplug=0" which I don't see a good
reason to exist, you can just say that this json object can be both used
via QMP or on QEMU's command line.

> The code that generates the json object comes from
> pci_add_qmp_device_add() which now also uses this new function.
> 
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxx>

With commit message reworded to remove the mention of "hotplog"
option: Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,


--
Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech