Re: [PATCH v3 14/23] xen/riscv: add very early virtual APLIC (vAPLIC) initialization support

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 6/22/26 4:55 PM, Jan Beulich wrote:
> On 17.06.2026 13:17, Oleksii Kurochko wrote:
>
> What does "very early" in the subject signify? This isn't about (very) early
> boot at all, so it's not quite clear on what scale of time the "early" is to
> be applied.
By "very early" I meant that this patch introduces only some very basic 
pieces and the vAPLIC driver isn't fully functional yet, so it was 
intended in the sense of an early development stage / first increment, 
not early boot.
I agree it would be better to rename it to:
  xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure

> > --- a/xen/arch/riscv/include/asm/aplic.h
> > +++ b/xen/arch/riscv/include/asm/aplic.h
> > @@ -15,6 +15,7 @@
> >   
> >   #include <asm/imsic.h>
> >   
> > +#define APLIC_DOMAINCFG_RO80    (0x80U << 24)
> Is the 80 in the identifier actually relevant? As the use site alll you care
> about is that you make sure to set r/o bits which aren't 0. Which ones these
> are can be entirely contained to the #define here.
Good point, the value doesn't need to be in the name. I'll rename it to 
APLIC_DOMAINCFG_RO and move the spec detail (bits 31:24 are read-only 
0x80) into a comment on the #define
/* domaincfg bits 31:24 are read-only 0x80 */
#define APLIC_DOMAINCFG_RO  (0x80U << 24)

Thanks.

~ Oleksii