Re: [PATCH v7 3/5] x86/asm: group inline string functions

[Borislav Petkov <bp@xxxxxxxxx>]

On Tue, Jul 21, 2026 at 12:56:44PM -0300, Mauricio Faria de Oliveira wrote:
> Group the __inline string functions in the same header.
> 
> Use <asm/shared/string.h> since __inline_memcmp() must remain there for use
> by arch/x86/boot/string.c.

"No functional changes."

> Signed-off-by: Mauricio Faria de Oliveira <mfo@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/shared/string.h | 26 ++++++++++++++++++++++++++
>  arch/x86/include/asm/string.h        | 21 +--------------------
>  2 files changed, 27 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/x86/include/asm/shared/string.h 
> b/arch/x86/include/asm/shared/string.h
> index 
> 166274e44f3cb49e3dccab3cdac281d67aef5d44..9714fbda8b734e20686bfb88a6ca857bfee59e1a
>  100644
> --- a/arch/x86/include/asm/shared/string.h
> +++ b/arch/x86/include/asm/shared/string.h
> @@ -2,6 +2,32 @@
>  #ifndef _ASM_X86_SHARED_STRING_H
>  #define _ASM_X86_SHARED_STRING_H
>  
> +/*
> + * The __inline string functions are grouped in this file for consistency and
> + * for use by arch/x86/boot code due to limitations on including 
> asm/string.h.

What limitations?

Either explain them or don't bother adding a comment. asm/shared/ is generally
an understood concept if you grep the tree and you don't really need a comment
here.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette