[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 1/5] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Hirokazu Takahashi <taka@xxxxxxxxxxxxx>
- Date: Thu, 23 Jul 2026 23:59:14 +0000
- Accept-language: ja-JP, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13dEvq/ewY/xexku2x0QJbrao3fVtokZRbReHLDqpNY=; b=SAQpWusMwKLyKdTeRa9qtzPof4rNxhBD1BtCJuf8JKWFewBea6ov2iKxufuJcf5ilQ7AByEA5/9HfZllr3Wx6LDpajYp96N0hNCqalzeP11e3wPxyIV8wGhu+Bxg99wUnFGghtoffB9TXKq51ER9Dq18SlFGb1ir9rc57RYwmMrS7wQG93nehsZt1SnZRGuy2pXACgfnn4u0+4j1zmVqzp6/RzGv4fE0RDEBLh3WuVaNV5Jb2IP5IHMC+OjYl3sKv6oMazqs8FeWZUf21jARqa4McSUEiVt2eFvkbT2BHL5OitlV3FCNq9xiVwS5oP+UXrZ6Na1Lv9ovO511rcPWhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d2zj00JxiSnkIe6YxPhbaj73QVIp8XqaMqzYI+d46gIOlzA2q5ZzdSnAW/jpCG1YLdiXVvM+UZWpe/T4WcgK3O70tn/H2gugj+8Ywdlrv6T/n/x4We4UutRK87gNokbDAHbqRpci4lNoDg76vuYPWzS6o4CgLr5wigJ3vgm+fl7Ev9zFJcvbb5FFfDMKMphyloEO9CBRI0+cjmWa9YOAqombSRE5Sc4BLnzS+wVs+GDrCwarjJPGZdEh3ZlOc5GbdVaPwDRAI451oS+v+oHle8rF4P6DenDuyrTMqXY7Iyz99WJOfRGVaWbup9TaszQtZnJrgR7StJ1H2GW+jCzQnw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: "Mykyta_Poturai@xxxxxxxx" <Mykyta_Poturai@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 23 Jul 2026 23:59:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdGGUCLSiIMXaUSUq2V68Fo2g2DrZ7KGyAgACkGPA=
- Thread-topic: [PATCH v7 1/5] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration
Hi Jan,
Thank you for the reviewing.
> > + for ( cpu = 0; cpu < nr_cpu_ids; cpu++ )
> > + {
> > + if ( !zalloc_cpumask_var(&cpu_topology[cpu].thread_sibling)
> > + || !zalloc_cpumask_var(&cpu_topology[cpu].core_sibling)
> > + || !zalloc_cpumask_var(&cpu_topology[cpu].cluster_sibling) )
>
> In v6 the || here were correctly placed. Why did they move?
I saw other code using leading || and tried to match that, but I'll revert it
back.
> > --- a/xen/common/cpu.c
> > +++ b/xen/common/cpu.c
> > @@ -46,6 +46,10 @@ const unsigned long
> cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)] = {
> > #undef MASK_DECLARE_2
> > #undef MASK_DECLARE_1
> >
> > +#ifdef CONFIG_GENERIC_CPU_TOPOLOGY
> > +struct cpu_topology *__ro_after_init cpu_topology;
> > +#endif /* CONFIG_GENERIC_CPU_TOPOLOGY */
>
> Looks like you also need to include xen/cpu-topology.h here. I can't see
> it being included implicitly.
Okay,
> > --- a/xen/drivers/acpi/Kconfig
> > +++ b/xen/drivers/acpi/Kconfig
> > @@ -2,6 +2,9 @@
> > config ACPI
> > bool
> >
> > +config ACPI_CPU_TOPOLOGY
> > + bool
> > +
> > config ACPI_LEGACY_TABLES_LOOKUP
> > bool
> >
>
> Did you forget to undo this change?
Oops, I will remove it.
> With all three adjustments:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> # common, acpi
Thank you,
Hirokazu Takahashi.
|
