[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] gnttab: unreachable code when GNTTAB_MAX_VERSION < 2
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Tue, 28 Jul 2026 17:40:25 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1785253225; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=GZRxfA2a9r/rHRg7Nrds5A0i0EklgCR+q1mAt63ipz4=; b=1vEIiLa7QY1YzBdjSESHCr5XdjfE+5HrQYP1sOkmCkHUWjZzQ7eDhQcx3K3JfLM5i2VN vNI6ciYHl53fJoSlYJI8hxjf2LACTtWE0bytQsVPJRKUeL+Kqn0o3ExV9pPNm3eiZxLP+ RQtgMxgOfAw0AHobrMgknridlDjd64PLIydSzq3RZGFSpC/eooV4OJPL6LhVcyvlKYwL+ 7kirKFCDSea1+5WUSbFGnpRLq5Lg+djJcO8TtjYLHUk6AeIhHJ5Fj44VlfUNnx+rwLkcC YWQ1ivFDu6x47GVLPO6BHsgg7htfPuvMraxOQ9QanUNaMgCFBdLXyTYSd7U3+CE9SEWFU 33OsOeKL6rg73HABuM2OjkoxF4/K9X4GkZrtFDP7yIeUtvaDlYnf87VO5eCKRRvtDsWeD F0xcXMVqUUZ97pXb59xYclYrYSPOLRA1fdUpvvShkXOO+FpvqLISGrmNl9QS/eFb60Cs9 cniUEJT+ZUSnDvnJV+hqYlIlij6K4zB/6b3oy53/6WVNCqGCcRanxSUHfZz9D3rd+OA0W 2nbRmM4fDycabyI2AAzIveuxWpdenypLgnPUy0bf204F7iS60XIUa9T6E7+m3lSuDXOr5 ePP8r+WEbLGUlVQtGJXDg9uLgFFeKEXS+XyxIifZ7Ist8/Z8lfvUmK8WeG4nDQg=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1785253225; b=sFjqgIsPBKBu79RsU303nPRSd8ZLDv7MhSBK8avI+bXpWRYnJYreLsVUHo1ttbIlTxH/ xKzaw6R/56vxeOGUdVYF6ifZvqZcmXLwaIoNKUtaCJzUhAx4z7JFXngEjCj38WcKjjLqv xsQ3MRcx+NQ7Zb2pVtoz16CaOjWKYmvtdfdr4fGb6jrReA2WDRnPdQsbP3RXNGB4J1cfu AH2CY6PgfT9Uo3Bf8oE/ZoUdYt9+iui87YrQfLlwpjHruMrR97FxWXvSKvmucNMLhYizl 3rDGPd/UUoNxQ9W4BG340hVF2lZJIK6x4Dvlhql+fFCNF0NSiPl8GQgD+oU/0Bs215sZc ufAIktbYcvIZ3YkI8XLSFMbvPxoM8teifYjkWWHku/x+81G/yIC32731Em0ZeZokScvqm OvdiWl9xlPWi7+Me34k7p0kRS0/KPM2JYkeDzjwk1sulZpkhoTvmXBA5uzwVcftA/piGR YUwKcLDgeJrxoUyzUL4fG8RkjgUqIerkdkoxq2LMY4Ju6RqOWTjWCpKrBk1CRPGttYkAa YszOk68O1M0cpgQwsZlav14XKa9elRIzVHNE4X0L4zjBowJm6hqnEIcess/zaYWChI6gj ulNGFpje3jSf5d0a7M7eZcAyLEcLiZPjOh4zMrBg5BrTt2LEE1dMWvHo9Onunec=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Tue, 28 Jul 2026 15:40:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-07-28 15:53, Jan Beulich wrote:
I'm surprised Eclair doesn't spot the large chunks of unreachable code
on
Arm, i.e. violations of Misra C:2012 rule 2.1.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
This pretty certainly isn't dealing with everything. For example, with
another helper the gt_version field could likely also become
conditional.
With some more effort the nr_status_frames field similarly could become
conditional.
[...]
Hard to judge only looking at the diff. Is this code unreachable in the
arm64-allcode analysis configuration as well?
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
