[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/i386/pc: xen: reinstate the "xenfv" machine alias



On 30/7/26 18:22, Dario Faggioli wrote:
Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc:
Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed
the Xen machine type that was providing the "xenfv" alias. As a
consequence, since the tools are apparently relying on such alias,
we're getting this, as soon as one tries to start a Xen (HVM) VM:

   qemu-system-i386: unsupported machine type: "xenfv"
   Use -machine help to list supported machines

Reinstate the alias and let it point to the only Xen machine we
still have.

Fixes: 7d2778dea3 hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 
machines
Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
---
  hw/i386/pc_piix.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 82457bdb16..0a911ce59e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -658,6 +658,7 @@ static void xenfv_machine_4_2_options(MachineClass *m)
  {
      pc_i440fx_machine_4_2_options(m);
      m->desc = "Xen Fully-virtualized PC";
+    m->alias = "xenfv";
      m->max_cpus = HVM_MAX_VCPUS;
      m->default_machine_opts = "accel=xen,suppress-vmdesc=on";
  }

Oops.

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>

Queued adding the @stable tag for backport.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.