[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 12/17] xen/riscv: extend exception tables with type and data fields
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Mon, 17 Aug 2026 13:39:32 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 17 Aug 2026 11:39:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/17/26 1:33 PM, Oleksii Kurochko wrote:
+ BUG_ON(!trap_info);
+
+ trap_info->sepc = csr_read(CSR_SEPC);
+ trap_info->scause = csr_read(CSR_SCAUSE);
+ trap_info->stval = csr_read(CSR_STVAL);
Do you really need to re-read all three registers here? Didn't you
read at least
scause already, in order to make it here in the first place?
Agree, ->scause and ->sepc are already read.
scause should be re-reaad as we don't save it inside cpu_user_regs
structure.
~ Oleksii
|
