[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
- To: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- From: "Haoxiang Li" <haoxiang_li2024@xxxxxxx>
- Date: Sat, 21 Nov 2026 14:40:51 +0800 (CST)
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=s110527 header.d=163.com header.i="@163.com" header.h="Date:From:To:Subject:Content-Type:MIME-Version:Message-ID"
- Cc: "Ostrovsky, Boris" <boris.ostrovsky@xxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "david.vrabel@xxxxxxxxxx" <david.vrabel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "tglx@xxxxxxxxxx" <tglx@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>
- Delivery-date: Sat, 21 Nov 2026 06:42:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
At 2026-11-21 06:06:58, "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote:
>
>I guess since you injected the error you didn't hit this in practice? If so,
>I'd
>think this would be a pretty low priority fix. The combo of rare scenario and
>close to zero user impact. Fine to be corrected though.
I agree that this failure is unlikely to happen. I found the missing cleanup
using a
static analysis tool and check the leak with fault injection. But hard to prove
that it will happen in normal userspace.
Regards,
Haoxiang Li
|