RE: [Xen-ia64-devel] vcpu_match_tr_entry

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

>current definition of vcpu_match_tr_entry is:
>#define vcpu_match_tr_entry(_trp,_ifa,_rid)             \
>    ((_trp->p && (_trp->rid==_rid) && (_ifa >= _trp->vadr) &&   \
>    (_ifa < (_trp->vadr + (1L<< _trp->ps)) - 1)))
>                                                          ^^
>Why -1 ?
>I suppose it is either <= (vadr + ps -1) or < (vadr + ps - 1) ?
>
>Thank you for any comment.
Percpu data of guest is put at high address, saying 0xffffffffffff0000,
Thus, vadr+1L<<ps is wrapped to 0, the correct statement maybe,
(_ifa <= (_trp->vadr + (1L<< _trp->ps)) - 1))

Thanks,
Anthony

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel