Re: [Xen-ia64-devel] PATCH: define guest_mode (instead of user_mode)

[Tristan Gingold <tgingold@xxxxxxx>]

On Tue, May 08, 2007 at 10:57:42AM -0600, Alex Williamson wrote:
> On Tue, 2007-05-08 at 15:26 +0200, Tristan Gingold wrote:
> > diff -r 8519e5db6510 -r 8e5083feaa52 xen/arch/ia64/vmx/vmx_process.c
> > --- a/xen/arch/ia64/vmx/vmx_process.c   Tue May 08 15:07:51 2007 +0200
> > +++ b/xen/arch/ia64/vmx/vmx_process.c   Tue May 08 15:24:57 2007 +0200
> > @@ -164,7 +164,7 @@ vmx_ia64_handle_break (unsigned long ifa
> >          if (iim == 0) 
> >              vmx_die_if_kernel("Break 0 in Hypervisor.", regs, iim);
> >  
> > -        if (!user_mode(regs)) {
> > +        if (ia64_psr(regs)->cpl == 0) {
> 
> Why is this first one a special case?  ie. why not !guest_mode(regs)
> same as the next one?  Thanks,
This is VTi code.  In my opinion, guest_mode makes sense only in PV mode.
Here we are testing wether kernel code is executing and not wether guest is.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel