Re: [Xen-ia64-devel] [PATCH] make p2m exposure compatible with suspend/resume

[Tristan Gingold <tgingold@xxxxxxx>]

On Wed, May 09, 2007 at 12:02:44PM +0900, Isaku Yamahata wrote:
> On Tue, May 08, 2007 at 03:32:22PM +0200, Tristan Gingold wrote:
> 
> > you should really define the TR used by the p2m in kregs.h.  Using a define
> > is less error-prone than a hard coded number (0x2).
> > 
> > (I don't object against this specific patch as the hard-coded number use is
> >  already commited in the tree).
> 
> 0x2 means DTR (and 0x1 means ITR). not index to TR.
You're right, I read too quickly!

> I agree that ia64_ptr(), ia64_itr() and ia64_itc() should use
> symbolical definition.
Yes, but this is linux code.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel