[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-users] Announce: rsysklogd

  • To: Michael Holzt <kju-xen@xxxxxxxx>
  • From: aq <aquynh@xxxxxxxxx>
  • Date: Mon, 23 May 2005 11:39:14 +0900
  • Cc: xen-users@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 23 May 2005 02:38:38 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sur50NGgB3a7/jkZm06KLBYH5UYSTGHVgbBNJRnxBfcvJIA9fqwPpt+cJ2D1uyWsQUlGy8VCp//oUePVYVvL6HqNK+8pGwI4ix0e5lj0lrW6LgvrVbTrFGHNVA+lF+QeutBDrxVdgaNHGJfxq0Tgn/LTzCOg7iBetVWtMPsNQ8c=
  • List-id: Xen user discussion <xen-users.lists.xensource.com>

On 5/23/05, Michael Holzt <kju-xen@xxxxxxxx> wrote:
> > Sounds great. Is there a debian-package availabel?
> Here you are: http://kju.de/projekte/rsysklogd/rsysklogd_0.1-1_i386.deb
> Regards
> Michael

Micheal, nice tool. but after quick glancing at your code, i spot a
buffer overflow bug. please fix it.

see below excerpt, with notes next to buggy lines:

  void do_klog_line(unsigned char *msg)
    unsigned char     buffer[BUFSIZE],
    int           len;
    /* copy the message */
    len = strlen(msg);                              <== this should be
len=sizeof(buffer) ?
    memcpy(buffer, msg, len);               <==== BoF here. 
other note: the code mixed with tab and spaces for indentation. could
you use either, but not too at the same time?

keep up the good job ;-)


Xen-users mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.