Re: [Xen-users] Announce: rsysklogd

[aq <aquynh@xxxxxxxxx>]

On 5/23/05, Michael Holzt <kju-xen@xxxxxxxx> wrote:
> > Sounds great. Is there a debian-package availabel?
> 
> Here you are: http://kju.de/projekte/rsysklogd/rsysklogd_0.1-1_i386.deb
> 
> 
> Regards
> Michael

Micheal, nice tool. but after quick glancing at your code, i spot a
buffer overflow bug. please fix it.

see below excerpt, with notes next to buggy lines:


^^^
  void do_klog_line(unsigned char *msg)
  {
    unsigned char     buffer[BUFSIZE],
                         *gtptr;
    int           len;
  
    /* copy the message */
    len = strlen(msg);                              <== this should be
len=sizeof(buffer) ?
    memcpy(buffer, msg, len);               <==== BoF here. 
^^^
  
other note: the code mixed with tab and spaces for indentation. could
you use either, but not too at the same time?

keep up the good job ;-)

regards,
aq

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users