Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Introduce posix-crypt internal library

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 11/28/19 12:39 PM, Simon Kuenzer wrote:
> Hi Costin,
> 
> as discussed offline, I think that if a program requires a libc with
> crypt functionality, it is bound to a libc that provides it. This is
> similar as the status quo in Linux, today. In this case, newlib is
> incompatible. In order to make it compatible, newlib would need to be
> extended - so I think it feels more correct to add it there.
> As I understand the reason of putting libc/posix functionality into
> Unikraft base was only related to common glue code. This code was coming
> from us and would affect most or all libc implementations we have. I
> think using the base repo to complete incomplete libc implementations is
> something else. If we want to do this, the correct way would then be to
> put in much more stuff: We have nolibc which is also "incomplete". But I
> think we shouldn't do this because this would imply that we would need
> to maintain much more code which is not ours.
> 
> If the concern is about having this functionality soon for porting
> applications: We are about to release a first working musl port soon.
> I'm currently preparing a related patch series that enables glueing
> musl's system calls directly to Unikraft. I can imagine that we will
> start using musl instead of newlib soon as it is out.
> 
> With this in mind: I prefer putting posix-crypt to newlib or as a
> separate library.

Agreed, Simon. We upstreamed it to newlib glue code.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel