[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] mini-os: Use a single start_info_ptr variable
Costin Lupu, le mer. 19 août 2020 18:22:14 +0300, a ecrit: > The problem that remains is that the logic in `shutdown.c`, which should > be arch-independent, uses start_info_ptr but it shouldn't. We can fix > this by adding an `arch_suspend()` function which would call the > hypercall on x86 Possibly, yes. > and would be empty on ARM. I would rather say to abort()? We don't want to silently ignore that something is still to be implemented. > However, I tried to build mini-os for ARM but I couldn't. The command I > used on Debian is: > > $ make -j32 CROSS_COMPILE=arm-linux-gnueabihf- MINIOS_TARGET_ARCH=arm > Config.mk:99: arch/arm/arch.mk: No such file or directory Uh :) > It looks like the ARM build has bigger problems. :-) Anyway, for the > patch I will send I'm gonna leave the HYPERVISOR_suspend() hypercall in > shutdown.c as you advised. Yes, that should be fine enough for porters to patch over. Samuel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |