Re: [MirageOS-devel] topkg'ing ocaml-crunch

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

On 3 Nov 2016, at 09:37, Federico Gimenez <federico.gimenez@xxxxxxxxx> wrote:
> 
> Hello everyone, I've started porting ocaml-crunch to topkg, have this so far 
> [1].

That's looking simpler!

> I have a problem with the tests, not sure what's the best approach to port 
> them given that now they are based on make and are testing the binary product 
> of the build process. Moreover, when i try to execute them with the oasis 
> based layout i get an error [2], maybe i'm doing something wrong.

The existing tests aren't too OPAM-friendly either, since they are not present 
in a `build-test` field (so the extra dependencies needed are not auto 
installable).

> So, i have a couple of questions:
> 
> * Are the tests for ocaml-crunch currently working? If so, how can i execute 
> them? what's the best approach for porting them to topkg?

The trunk version of ocaml-crunch has had the interface changes from the main 
mirage trunk applied, so you will need to `opam remote add dev 
https://github.com/mirage/mirage-dev.git` to get the development version of all 
the right packages.

After that, you will need to add `mirage-types-lwt {test}` as a test dependency 
so that the right libraries are available in the opam file.  Once you have 
that, the tests should work.

> * If they are not working, how should i write a new test for the package? 
> what should i test in this concrete case and from which perspective (binary 
> consumer vs library consumer)?


The tests seem very basic at the moment, so writing a topkg + bos test that 
writes the .ml files into _build/_tests, invokes the compiler on it, and 
verifies that the resulting compiled ML outputs the crunched contents would be 
useful.

This is a very non-traditional test as it involves calling the compiler 
multiple times, so it's probably the most complicated part of the topkg port!

regards,
Anil
_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel