[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[MirageOS-devel] removing global use of Result

  • To: mirageos-devel <mirageos-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Anil Madhavapeddy <anil@xxxxxxxxxx>
  • Date: Mon, 3 Sep 2018 14:10:51 +0100
  • Delivery-date: Mon, 03 Sep 2018 13:11:05 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=recoil.org; h=from :content-type:mime-version:subject:message-id:date:to; q=dns; s= selector1; b=gJTbeq5HJlrGF6Yvntq9t2mVMWLmDBvznmUWhplalVOVNtvNzo1 FES4O+z/zAScvXjJHDqg0O2ttoaaVHGYV2wItOvrlf7+4pESA/gZuoDo7m1Kh0nK 6D65AkHly18+b1rk+z7wm6YhH9UCTjrglPjQmsws31sKflzNHiAv7fd0=
  • List-id: Developer list for MirageOS <mirageos-devel.lists.xenproject.org>

Dear all,

I noticed in https://github.com/mirage/mirage-tcpip/pull/372 that Hannes makes a good point about globally opening the Result module, which we used to do for compatibility for compilers pre-4.03.0.  

Nowadays, in the forthcoming OCaml 4.08 release, there will be a more extensive Result module with more functions available, so we should start removing use of the older compatibility shim just in case the shadowed functions cause issues.

So if you spot use of the `result` package and a global Result module in any other Mirage libraries, feel free to submit PRs along the lines of the one above to clean them up and prepare us nicely for 4.08.0.

MirageOS-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.