Re: [PATCH 1/2] Allow user to specify desired build architecture

[Niko Tsirakis <niko.tsirakis@xxxxxxxxx>]

Awesome - thank you!

--Niko

On Tue, Nov 10, 2020 at 4:22 AM Paul Durrant <xadimgnik@xxxxxxxxx> wrote:
>
> [snip]
> > > > >
> > > > > > I would suggest using
> > > > > > [string]::IsNullOrEmpty($Arch)
> > > > > > Instead of
> > > > > > $Arch -eq ""
> > > > > >
> > > > >
> > > > > Agreed. I can make the change while committing so no need for a v2.
> > > > >
> > > > > Acked-by: Paul Durrant <paul@xxxxxxx>
> > > >
> > > > Actually, I jumped the gun here. Having started to apply this I realize 
> > > > it's not going to work
> > > because of the optional '$Sdv'
> > > > parameter after it. IOW how do we do a default (IOW both x86 and x64) 
> > > > build with the sdv option?
> > > >
> > > >   Paul
> > > >
> > >
> > > Admittedly my powershell isn't too strong, but wouldn't ".\build.ps1
> > > <free/checked> -sdv" do the trick? The SDV param is a switch.
> > >
> >
> > Good point... misread it (and I'm not particularly au fait with powershell 
> > either). Let me check it
> > works properly. Thanks!
> >
>
> All good. I'll apply these changes for all drivers.
>
>   Paul
>