[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] Fix div by zero in xenvif if no queues.


  • To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Martin Harvey <martin.harvey@xxxxxxxxxx>
  • Date: Mon, 21 Mar 2022 17:23:19 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YuYL1s1V3XkkGJcNqhCkO7Xfynff14yo9E6xqmU2kKs=; b=ExT1AQjpk/O+U32AnPlRzhA3d5YTGv3OQ21U0y4tTn+zLi/WWP5Akb9rRs8/OHRbY20RzHZ6SyPP3jAVyMPpiEyfWqtCFEVjUNZKFfDN4MYa6ylir642wyBtp4quTltyPKNyLX6hgeVm1mwcFbaf/5hLTLC/Y1JCszjFaMcOqqgf6jzRazeSUnXopWlDbwu13ZiFiSZLz8e9bWQqRfhO/gkEfsXl1hJGAfWMEl48HUTFuxdIvOrFmOoqQKInKn+c2PI3ieBJtCTcNSbxh1+svYl1nUPUnw3T45w2zur+N37a9AAUTVfTbbch6lrs+ltq5HHlsQEjPBUzkEcOzLPxrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=en+BefJyw1KN3QZIcMxRKCKOq0u8kFn0HVl+kvCyNZSRqlG96KVHfE2KXVHQTTBr+PMA44ASfFM70yEeivwuBUniB9bQ7CmUChdIjVDez5slsyg0mlIFdXHG8ZUo7EATxG9enN7RebbRGryvbDkA3UMvsejetLSrq+MKhYeoBAO+wShT7nIQ1AhvBrrs9LGMYsLZjH1W3KH9CDJN5HYbIaFXJDLlfI/U+tj4i3gr+R6Tv0sO+67nn0SZSTMYltWd/WU2pfc0GAPeXjSvOnT6YG2yclfAv+5ygWODbT22DrWVBMZFUQffw20NLY1Nzp84UWdz/O9n1+bkCVuCV2hkoQ==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Delivery-date: Mon, 21 Mar 2022 17:23:30 +0000
  • Ironport-data: A9a23:BDMZHa4GkYPJ9rjqFYpnpwxRtEHHchMFZxGqfqrLsTDasY5as4F+v jBMUDuAa/nfa2CnL9x1Ydi1/EkAuMDWmodkTFRl/igwHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPjWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS6bhlzfafogt8iaBRVMAsnLPN635HIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsas2t8zDefDf88X53Sa67L+cVZzHE7gcUm8fP2O ZRGOGExPUuojxtnZ29JNa0fp96SvV6veH5E+WiVh7Nw2j2GpOB2+Oe0a4eEEjCQfu1Kn0Ddv nyD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3uZjnVm71mEVThoMWjOGTeKR0xDkHYgFc gpNp3Ro/fNaGFGXosfVVTqm+j2OmgQnZOFdHs4QsRDT9o367FPMboQbdQJpZNsjvc4wYDUl0 F6Vgt/kbQBSXK2ppWG1renN827rUcQBBSpbPHJfE1NZizX2iNtr5i8jWOqPB0JcYjfdPTjri w6HoyEl71n4pZ5ajv7rlbwrbt/Fm3QocuLXzliMNo5GxlkgDGJAW2BPwQKHhcus1K7DEjG8U IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QE/RsF4rmT0oC/LkWVsDNZWfhoBDyr5UWWxP B+7Vf15uve/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU b/GIZfEJStLUsxPkWvpL9rxJJd2n0jSM0uIHsulp/lmuJLDDEOopUAtawLfMLpmsPva/G04M b93bqO39vmWa8WnCgH/+o8PN1Eaa389AJH9sctMceCfZAFhHQkc5zX5m9vNp6QNc3xpq9r1
  • Ironport-hdrordr: A9a23:sRyWkqxN4LohJpUrwgBvKrPwA71zdoMgy1knxilNoERuA6ilf8 DHppsmPGzP+VEssRAb6Kq90ca7MBDhHPJOjLX5Xo3SITUO2lHYTr2KhLGKq1aLJ8S9zJ856U 4KScZD4ajLbWSS+vya3ODXKbodKZK8gcaVbK/lvg5QpRcDUdAZ0+5WMHfhLnFL
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AQHYOHVErur6M9Oay0m6lfwVxs2ql6zG/w8AgAMM6lCAAAji0IAACMQAgAABpIA=
  • Thread-topic: [PATCH] Fix div by zero in xenvif if no queues.


-----Original Message-----
From: Durrant, Paul <xadimgnik@xxxxxxxxx> 


> I really wouldn't go down that rathole. If the frontend cannot implicitly 
> trust its backend (or the toolstack that creates it) then all bets are off 
> IMO.

Well, we may yet have to for the sake of software robustness. I'll re-look 
through the logs and the various possible error cases, and get back to you on 
this one. I think this falls under the category of "defensive programming". It 
would be nice to have a clear idea of what's happened before it all went 
belly-up. I'll get back to you.

MH.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.