[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] iommu/crash: Interrupt remapping is also disabled on crash



commit 53fd1d8458de01169dfb56feb315f02c2b521a86
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Tue Apr 16 10:34:32 2013 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Apr 16 10:34:32 2013 +0200

    iommu/crash: Interrupt remapping is also disabled on crash
    
    This fixes a regression side-effect caused by:
      IOMMU: properly check whether interrupt remapping is enabled
        git: fae0372140befb88d890a30704a8ec058c902af8
         hg: 26742:e1ec14bad0cb
    
    On the crash path in nmi_shootdown_cpus(), we shut down the IOMMU, then
    disable the IOAPIC.
    
    On systems which support interrupt remapping, the variable iommu_intremap
    remains set, meaning that disable_IO_APIC() issues interrupt remapping
    invalidate requests.
    
    IOAPIC interrupt remapping used to be conditional on iommu_enabled, but is 
now
    conditional on iommu_intremap, following the above changeset.
    
    This behaviour can be fixed by also indicating that interrupt remapping is 
not
    enabled after shutting down the IOMMU.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/drivers/passthrough/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index c5906ab..93ad122 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -603,7 +603,7 @@ void iommu_crash_shutdown(void)
     const struct iommu_ops *ops = iommu_get_ops();
     if ( iommu_enabled )
         ops->crash_shutdown();
-    iommu_enabled = 0;
+    iommu_enabled = iommu_intremap = 0;
 }
 
 int iommu_do_domctl(
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.