[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fixing iopl and ioperm




On 14 Jun 2005, at 14:21, Keir Fraser wrote:

Frankly, fixing this LTP test case will be a pain. If I have correctly described what's going on then let's ignore it at least for now -- it is not indicative of a real bug and it is entirely harmless. LTP is a measure of stability for us, but passing every LTP test is not an end in itself (we should understand the failures though).

Actually this is perhaps worth fixing, just to prevent a super-user process from denying I/O access to the kernel itself (by running iopl(0)). But please ignore the test failure in your patch: I can fix it properly next week.

Also, please don't change set_bitmap() unless you are fixing a bug to make it work with x86_64. I don;t care about simplifying its implementation -- I'd rather keep the diff against the native i386 implementation as small as possible. As I originally said, I wonder if you actually need any changes to xen/i386/kernel/ioport.c at all.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.