[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] eliminate duplicate stack trace during bad page fault



Other than native i386 code, the page fault handler in the guest for whatever 
reason ran a stack_trace even though another one is run from die(). Since 
screen space is limited, duplicating (perhaps long) stack traces seems quite 
wasteful. Patch removing this duplication below/attached.

Jan

--- 2.6.11-xen/arch/xen/i386/mm/fault.c 2005-07-01 09:14:09.081412024 -0700
+++ nxen-guest/arch/xen/i386/mm/fault.c 2005-07-01 09:15:22.188298088 -0700
@@ -474,7 +474,6 @@ no_context:
                       machine_to_phys(page));
        }
 #endif
-       show_trace(NULL, (unsigned long *)&regs[1]);
        die("Oops", regs, error_code);
        bust_spinlocks(0);
        do_exit(SIGKILL);


Attachment: xenlinux-duplicate-trace.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.