[Xen-devel] bvt scheduler has two bugs?

["Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx>]

Recently,  I look in scheduler.
So, I think so that Xen 2.0.x has two bugs.

One is about showing schedule parameter.
Other is Domain initialization.

Former locales in ./tools/python/xen/lowlevel/xc/xc.c 
This bug is that can not transfer parameter into python object in
correct.

- return Py_BuildValue("{s:i,s:l,s:l,s:l,s:l}",
                         "domain", dom,
                         "mcuadv", mcuadv,
                         "warpback", warpback,
                         "warpvalue", warpvalue,
                         "warpl", warpl,
                         "warpu", warpu);

+ return Py_BuildValue("{s:i,s:l,s:l,s:l,s:L,s:L}",
                         "domain", dom,
                         "mcuadv", mcuadv,
                         "warpback", warpback,
                         "warpvalue", warpvalue,
                         "warpl", warpl,
                         "warpu", warpu);


Latter is included in sched_bvt.c or its besides.
I can not find detail location.
This bug is that set warpl and warpu parameters into twice when domain
is created.

If new domain is created,  Is its domain created based on temporary
domain?

In Function bvt_add_task(), these two parameters is set in

>    inf->warpl       = MILLISECS(2000);
>    inf->warpu       = MILLISECS(1000);

In Function bvt_adjdom(), these two parameters is set in 

>  inf->warpl = MILLISECS(warpl);
>  inf->warpu = MILLISECS(warpu);

If new domain is created by xm command, these functions are called.
Therefore, these parameter is set in like follow.

   inf->warpl = MILLISECS(MILLISECS(2000));
   inf->warpu = MILLISECS(MILLISECS(1000));

However, in the case Domain-0, only bvt_add_task() is called.

This is interface design error ?  or  programming error ?


I avoid by removing MILLISECS in bvt_adjdom() in transient.



UCHIDA


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel