Re: [Xen-devel] Changeset for reisermodule x86_64 compilation w/ -Wall

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Oct 11, 2005, at 3:14 AM, Charles Duffy wrote:

> Compiling with -Wall is failing for me without application of this 
> patch. I'm fairly sure someone else has independently proposed (pretty 
> much) the same thing, but given that it didn't get applied, I'm 
> reproposing it here.
> # HG changeset patch
> # User cduffy@xxxxxxxxxxx
> # Node ID f3f8213f8d895c1b4e29647132aaea8633fb4825
> # Parent  e69413dca6844c87885121a7360fa7c2b11cdea9
> fix 64-bit compilation
>
> diff -r e69413dca684 -r f3f8213f8d89 
> tools/pygrub/src/fsys/reiser/reisermodule.c
> --- a/tools/pygrub/src/fsys/reiser/reisermodule.c       Sat Oct  8 
> 09:22:01 2005
> +++ b/tools/pygrub/src/fsys/reiser/reisermodule.c       Tue Oct 11 
> 07:51:18 2005
> @@ -46,7 +46,7 @@
>
>         if (!dal) return;
>
> -       close((int)dal->dev);
> +       close((size_t)dal->dev);
>         dal_free(dal);
>  }
I don't understand this change. My close(2) man page says close takes 
an int, not a size_t.
Charles, what is the exact -Wall error you're seeing? I can't seem to 
find "dal", but just a guess... is 'dal->dev' a 'void *'?
--
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel