[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] misleading names in xen memory management code


  • To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Sat, 29 Oct 2005 10:03:19 +0800
  • Delivery-date: Sat, 29 Oct 2005 02:01:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcXcLO8xmuQY6DAYQpmS7aG4WO2Z4g==
  • Thread-topic: misleading names in xen memory management code

Keir, I think we have some misleading names in xen memory management
code:
1) #define page_to_pfn(_page)  ((unsigned long)((_page) - frame_table))
Actually, it should be page_to_mfn.

2) #define l1e_from_pfn(pfn, flags)   \
    ((l1_pgentry_t) { ((intpte_t)(pfn) << PAGE_SHIFT) |
put_pte_flags(flags) })
Seems l1e_from_mfn(mfn, flags) is much more clear.

Am I right?

-Xin


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.