[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Build problems: references to init_mm in pgtable*.h


  • To: Stephen Tweedie <sct@xxxxxxxxxx>
  • From: Christian Limpach <christian.limpach@xxxxxxxxx>
  • Date: Tue, 13 Dec 2005 19:34:27 -0800
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 14 Dec 2005 03:36:07 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r83ynYpE0AP87EQhVkzTvUMh8Iv0tV5eOzrR2JujpZsqA3RCIe/YsJ7Hi5p+fYnxxvzcT3tVi5YY54n0icKhncXysZ83gofVMfuxec95B6HSJyXzhxrfzzg0U3XCXXP3Mp2PZ4EmjTVhYxgCTG+vuFB5ovlQFYvEoX6xvNDOKXQ=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 12/5/05, Stephen Tweedie <sct@xxxxxxxxxx> wrote:
> My normal xen .config will not build on recent linux-2.6-merge.hg trees.
> The problem is the
>        include/asm-i386/mach-xen/asm/pgtable-2level.h
> and
>        include/asm-i386/mach-xen/asm/pgtable-3level.h
> files, which reference "init_mm" without ever pulling in a definition of
> those files.
>
> Whether you see the problem or not depends on the .config; most files
> which include the pgtable*.h includes already pull in sched.h (which is
> where init_mm is declared), but not all do so.  Trivial patch attached,
> but it's not necessarily the best solution as we don't want sched.h
> changes polluting mm .o's unnecessarily.

I've changed the set_pte_at and set_pte_at_sync inline functions to be
macros.  This way, init_mm only needs to be defined where these macros
are used.
Does this fix all the errors you're seeing?

     christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.