[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>> I like the name 'lapic' rather than 'apic' as it explicitly >> disambiguates from 'ioapic'. And it's only one more character. >> >> Placing the hvm info definitions in public/io/ioreq.h is not >right. It >> probably needs its own header file. How about a new subdirectory >> include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h? > >Also, does anything in Xen actually use the nr_vcpus variable? There's >an accessor function for obtaining its value, but noone calls it, nor >can I see any reason someone would want to in the future. There's >already a setmaxvcpus dom0_op. Seems the Xen code that reads that part >of the hvm_info struct could be removed. > SMP VMX guest will use it. Maybe in the future when we have CPU hotplug support in VMX guest, we don't need it any longer, but that's need more thoughts :-). -Xin _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |