Re: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 3 Jan 2006, at 12:47, Li, Xin B wrote:

> In current implementation, if 'lapic=1', both lapic and ioapic are
> enabled for VMX guest, and this is what we prefer.
> VMX guest has 3 PIC/APIC modes:
> 1. no lapic and ioapic, only PIC, and this is the default option.
> 2. both lapic and ioapic, enabled by 'lapic=1' in VMX config file.
> 3. only lapic and PIC, no ioapic. No such option, but VMX guest can 
> only
> use lapic by not using its ioapic.
> This is the reason why I made this change.
Okay, that makes sense.

> > Placing the hvm info definitions in public/io/ioreq.h is not right. It
> > probably needs its own header file. How about a new subdirectory
> > include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h?
> Yes, I like this new directory for VMX guest using, we do have some
> structures defined twice.
You'll send another patch?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel