[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [ PATCH 2.6.16-rc3-xen 1/3] sysfs: export Xen hypervisor attributes to sysfs
On Tue, Feb 21, 2006 at 09:36:35AM -0500, Mike D. Day wrote: > +---properties > +---changeset Just curious, but what is a "changeset"? > The xen_sysfs module has a tri-state Kconfig so it can be built-in or > loaded as a module. > > The module is in three patches: This patch has it's leading spaces eaten by your email client and can not be applied :( > diff -r a05e56904e7e -r d296aaf07bcb xen/include/public/version.h > --- a/xen/include/public/version.h Mon Feb 20 23:01:50 2006 +0000 > +++ b/xen/include/public/version.h Tue Feb 21 08:11:03 2006 -0500 > @@ -1,8 +1,8 @@ > /****************************************************************************** > * version.h > - * > + * > * Xen version, type, and compile information. > - * > + * > * Copyright (c) 2005, Nguyen Anh Quynh <aquynh@xxxxxxxxx> > * Copyright (c) 2005, Keir Fraser <keir@xxxxxxxxxxxxx> > */ > @@ -17,6 +17,7 @@ > > /* arg == xen_extraversion_t. */ > #define XENVER_extraversion 1 > +#define XENVER_EXTRAVERSION_LEN 16 > typedef char xen_extraversion_t[16]; Shouldn't the typedef use the #define in it, so that if you change it, the array size is properly changed too? thanks, greg k-h _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |