[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] gdbserver-xen: fix corefile access

On 3 Mar 2006, at 01:28, Horms wrote:

Sorry, scratch that. I think they can just be merged into one
function, I'll try and get a patch together.

Do you think it would be better to pass the isfile flag in the form
of PTRACE_ATTACH|XC_PTRACE_FILE as the third argument to xc_ptrace,
or parhaps use the last argument to xc_ptrace, edata (or perhaps the
second last one, eaddr), which are unused for ATTACH.

Having xc_ptrace_thread/xc_ptrace_core *internally* in libxenctrl would be fine, but there should be only one public function (xc_ptrace). You can update PTRACE_ATTACH as you wish -- I guess adding a new ptrac ecommand would be cleaned: PTRACE_ATTACH_COREFILE would be okay.

And yes, I expect you can give the same treatment to xc_waitdomain. It probably should be a no-op when debugging a core file (although currently it loads the core file state into memory, which is weird but I guess works okay).

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.