[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] gdbserver-xen: fix corefile access

On 3 Mar 2006, at 11:15, Horms wrote:

I have made a first pass at this, passing isfile as the data argument
to xc_ptrace() ATTACH. Its a little rough, but I wanted to get it out
for feedback before I head off for the day.

There are 4 patches attached, which need to be applied in order.
Please let me know if posting patches in this way is a problem.
And of course, please let me know of any and all objections
so that I can refactor (or explain) accordingly.

Yeah, diffstat tells me that you probably have the right approach (more lines deleted than added). I'd prefer fewer but bigger patches. e.g., merge the first three 'cleanup' patches into one.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.