Re: [Xen-devel] [PATCH] Non-polling trace record access

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 31 Mar 2006, at 18:54, Rob Gardner wrote:

> This is the kernel side code to implement a virtual irq that gets sent 
> when the xen trace buffers become half-full. This allows userland 
> tools such as xentrace and xenmon to avoid polling for new trace 
> records. A future patch will include support for this in XenMon, along 
> with various other enhancements and bug fixes.
>  This patch has been tested on x86, x86-64, and x86 SMP machines.
Please re-sync the patch with current tip, and also I think your 
interrupt holdoff logic is unnecessary. I think you can get rid of 
last_virq_sent and test '(buf->prod - buf->cons) == t_buf_highwater'. 
No need for '>=' because the producer is incremented by one each time 
trace() is called so you are bound to equal t_bug_highwater before you 
become greater than it.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel