[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] question (bug?) in xeno-linux code


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Runting Shi" <rshi@xxxxxxx>
  • Date: Tue, 18 Apr 2006 16:41:25 -0400 (EDT)
  • Delivery-date: Thu, 20 Apr 2006 03:12:18 -0700
  • Importance: Normal
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Hey, in xeno-linux, arch/i386/mm/pgtable-xen.c (line 363),

why are we doing set_pgd(&pgd[USER_PTRS_PER_PGD], __pgd(1 + __pa(pmd)));

shouldn't it be set_pgd(&pgd[USER_PTRS_PER_PGD + i], __pgd(1 + __pa(pmd))) 
or something?

I am just wondering why the for loop is there at all....


Thanks,

Elaine


for (i = USER_PTRS_PER_PGD; i < PTRS_PER_PGD; i++) {
                        pmd_t *pmd = kmem_cache_alloc(pmd_cache, GFP_KERNEL);
                        if (!pmd)
                                goto out_oom;
                        set_pgd(&pgd[USER_PTRS_PER_PGD], __pgd(1 + __pa(pmd)));
                }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.