Re: [Xen-devel] [patch] "frame number" size in hypercall ABI

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-04-19 at 19:25 +0100, Keir Fraser wrote:
> On 19 Apr 2006, at 17:44, Hollis Blanchard wrote:
> 
> > Attached is the updated patch, with typos fixed and a couple other
> > corrections. I've also added the type to arch-x86_64.h and arch-ia64.h,
> > so I think the patch is ready to be applied.
> 
> What about the Linux kernel -- shouldn't that be changed too? At least 
> where it handles arrays of longs passed to memory_op()?
> 
> Inside Xen, does shadow.h really need changing at all? Once entries are 
> unpacked from an array by a hypercall they could just be passed round 
> as longs, right?
> 
> Sorry about the to'ing-and-fro'ing but we need to make sure interface 
> changes are complete and correct and this one is inevitably pretty 
> far-reaching.

So are you saying you want the patch to include Linux kernel changes?
But not Xen changes (e.g. shadow.h) other than right at the interface?

I needed to change all users in libxc because they all index into
page_array[] as unsigned long. Theoretically speaking you could have the
same problem within Linux and Xen as well. The word "unpacking" suggests
a conversion step, which is something I'm not introducing here.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel