Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64

[Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>]

On Wed, Apr 26, 2006 at 06:34:24PM +0900, Isaku Yamahata wrote:
> On Wed, Apr 26, 2006 at 10:19:49AM +0100, Christian Limpach wrote:
> > On 4/26/06, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:
> > >On Tue, Apr 25, 2006 at 11:00:52AM +0100, Christian Limpach wrote:
> > >
> > >> I also don't like the ifdef on dma_map_page since it requires you to
> > >> #define it to something else to override it instead of implementing
> > >> it.
> > >>
> > >> I prefer to have #if defined(__i386__) || defined(__x86_64__) (maybe
> > >> with a comment stating !defined(__ia64__)) which will make it clear
> > >> why these are ifdef'ed out.
> > >
> > >I attached the updated patch.
> > 
> > Cool, although I'm still wondering about dma_declare_coherent_memory():
> > If you have your own dma_declare_coherent_memory(), don't you then
> > need to #define ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY so that you don't
> > get the default implementations in linux/dma-mapping.h?
> > 
> > Do you use the default dma_declare_coherent_memory() from
> > linux/dma-mapping.h and thus don't define
> > ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY?
> 
> xenLinux/IA64 uses the default dma_declare_coherent_memory().
> So ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY isn't defined.

Ah ok, then it makes sense.  I'll apply the patch.  Thanks.

    christian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel