[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen



* Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> [2006-05-15 12:37]:
> 
> On 15 May 2006, at 18:27, Ryan Harper wrote:
> 
> >Well, I *tried* to use drivers/acpi/numa.c first, and I quit after I 
> >had
> >to pull in more than few headers; it was just too intertwined.  I think
> >using the i386 parser and calling into the x86_64 logic should be
> >do-able.  I'll give it a go and post back here with the results.
> 
> Pulling in a few more header files (presumably from include/acpi?) 
> would be okay, as long as you don't end up grabbing loads of .c files. 
> But really i don't see the problem here -- drivers/acpi/numa.c hardly 
> pulls in very many header files. It grabs acmacros.h and acpi_bus.h, 
> both of which Xen has already.
> 
> Just take a logical look at that file: it clearly doesn't use much ACPI 
> machinery and I really think it should be possible to port it down to 
> Xen with not much modification. Unless you can give a concrete example 
> why I'm wrong. :-)

You weren't.  It has been a while since I gave that a try (last summer
using 2.6.11).  Turns out that it does compile without any significant 
work (couple of defines required, but nothing that wouldn't come with 
NUMA header files).

What I'm fighting now is getting linux/arch/x86_64/mm/numa.c to build.
Some of the structures to track numa info (struct pglist_data) are
rather linux specific and include lots of structures related to Linux mm
zones, check out linux/include/linux/mmzone.h.  I attempted to avoid
bring in that in, but the pfn_to_nid/phys_to_nid macros are based on
memnodemap array.  

My current thought is to trim down struct pglist_data into something
that has the minimum information needed to populate the memnodemap
array.  I'll see how far that goes.

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.