[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6

On 2 Jun 2006, at 11:05, Jan Beulich wrote:

Add backing support for HDIO_GETGEO ioctl to blkfront.

Inspired by an earlier patch from Charles Coffing.

Does this have any effect? It looks to me as though HDIO_GETGEO is handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just remove that case from our ioctl switch statement and define a 'getgeo' function hook?

Given that this patch can't have any effect, what drove you guys to implement it? :-)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.