Re: [Xen-devel] [PATCH, resend] blkfront: ioctls/geometry, 2.6

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 02.06.06 12:19 >>>
>
>On 2 Jun 2006, at 11:05, Jan Beulich wrote:
>
>> Add backing support for HDIO_GETGEO ioctl to blkfront.
>>
>> Inspired by an earlier patch from Charles Coffing.
>
>Does this have any effect? It looks to me as though HDIO_GETGEO is 
>handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other 
>blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just 
>remove that case from our ioctl switch statement and define a 'getgeo' 
>function hook?

But that is exactly what the patch does. It instead adds a getgeo function to 
vbd, which is what several other drivers
also have, and which is what backs blkdev_ioctl()'s handling of HDIO_GETGEO.

>Given that this patch can't have any effect, what drove you guys to 
>implement it? :-)

We saw GrUB failing when used inside a domU.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel