Re: [Xen-devel] [patch] ACM ops interface

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Thu, 2006-06-08 at 17:11 +0100, Keir Fraser wrote:
> On 8 Jun 2006, at 16:01, Hollis Blanchard wrote:
> 
> > If the ACM ops were always passed in a union, we could replace the 
> > first
> > switch with a single copy_from_user(), and also guarantee that
> > "interface_version" is always in the right place (it's only there
> > coincidentally now). What do you think?
> 
> The interface was deliberately changed away from that style for 
> consistency with other hypercalls. Also to allow larger argument 
> structures to be added to the interface later without breaking backward 
> compatibility (inflating the size of the union).

Ah, that makes sense. Too bad it will uglify the already unpleasant
handle hacks PPC needs to do.

Are you planning to do something similar for the dom0_op structure?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel