[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH - proposed] XI Shadow Page Table Mechanism]

  • To: zhu <vanbas.han@xxxxxxxxx>
  • From: "Robert Phillips" <rsp.vi.xen@xxxxxxxxx>
  • Date: Fri, 30 Jun 2006 08:24:31 -0400
  • Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx, "Robert S. Phillips" <rphillips@xxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 30 Jun 2006 05:24:53 -0700
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=KI5nfrV1yfuPYcJPfAHfUuRPsu/x4VFKmiuUOq6yGPGk2jTjON982YUH1TT9C2dgssKLre6VGaYM/qhI7/odV7ZrSJjPjd4nFk4lSNsP5/F6ciWutjQObkUIfLd4AJ01m83tvPjn+S83G5kSeaEf0TOVB5Hb7YaKEgLaPiSwl2I=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Hi Han,
You are right again.  I have not seen this cause a problem but we'll certainly fix it.
-- rsp

On 6/29/06, zhu < vanbas.han@xxxxxxxxx> wrote:
Hi, Robert,
I found out another confusing code snippet:
in void xi_invl_mfn(struct domain *d, unsigned long mfn)
     if (ext && pfn < ext->large_page_aligned_size)

According to the code, it should be
     if (ext && (pfn>>SPT_ENTRIES_ORDER) < ext->large_page_aligned_size)

If I made any mistake, please point it out.
Best Regards,

Robert S. Phillips                          Virtual Iron Software
rphillips@xxxxxxxxxxxxxxx                Tower 1, Floor 2
978-849-1220                                 900 Chelmsford Street
                                                    Lowell, MA 01851
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.