[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH - proposed] XI Shadow Page Table Mechanism]
- To: zhu <vanbas.han@xxxxxxxxx>
- From: "Robert Phillips" <rsp.vi.xen@xxxxxxxxx>
- Date: Fri, 30 Jun 2006 09:18:50 -0400
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 30 Jun 2006 06:19:15 -0700
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=CfT+c5Zdi+WMTTrhZ/178LVHaRP2qQdTI9oPAEg7T2+rcyO7ZQcTIWDPePbBopzZ0avDRhs4fWeEdQrHFXm38gRpbFt6Lmv4U9TWscmU4I5BMKD51XB+yKTgI4f/++Gir6+NpOLHIl1FeeicXekfFNSan5DDKbSt3hcLsbgjQOc=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
Yes, that's true. If the caller supplied a bogus PFN (one larger than
ram size), we'd crash.
BTW, we are avoiding use of grant table transfers because they fragment
PSE pages.
-- rsp
On 6/30/06, zhu <vanbas.han@xxxxxxxxx> wrote:
I'm afraid it could trigger some certain problems only when you open l2
PSE flag and use grant table to transfer pages between domains. I'm not
very sure about it. :-)
_______________________________________________________
Best Regards,
hanzhu
Robert Phillips 写道:
> Hi Han,
> You are right again. I have not seen this cause a problem but we'll
> certainly fix it.
> -- rsp
>
> On 6/29/06, zhu <
vanbas.han@xxxxxxxxx> wrote:
>>
>> Hi, Robert,
>> I found out another confusing code snippet:
>> in void xi_invl_mfn(struct domain *d, unsigned long mfn)
>> if (ext && pfn < ext->large_page_aligned_size)
>>
>> According to the code, it should be
>> if (ext && (pfn>>SPT_ENTRIES_ORDER) < ext->large_page_aligned_size)
>>
>> If I made any mistake, please point it out.
>> _______________________________________________________
>> Best Regards,
>> hanzhu
>>
>
>
--
--------------------------------------------------------------------
Robert S. Phillips Virtual Iron Software
rphillips@xxxxxxxxxxxxxxx Tower 1, Floor 2
978-849-1220 900 Chelmsford Street
Lowell, MA 01851
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
