[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [XEN] BUG() places console in sync mode.

On 30 Jun 2006, at 16:57, Jimi Xenidis wrote:

[XEN] BUG() places console in sync mode.
Also move the BUG code out of line.
Original patch from Jimi Xenidis.
diff -r 25c6ea6d4024 -r 1d17ddd9e45d xen/include/xen/lib.h
+extern void __bug(char *file, int line) __attribute__((noreturn));

I can understand panic() being "noreturn", which it isn't, but __bug() should not, since It should result in some debugging logic (gdb, xmon, whatever) that could potentially continue.

Is it used in any contexts other than where some pretty serious error has occurred and all you want to do is postmortem? I don't think continuing would ever be be helpful or sane.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.