Re: [Xen-devel] [PATCH] console: allow a panic to be triggered from the xen console

[Horms <horms@xxxxxxxxxxxx>]

On Mon, Jul 10, 2006 at 09:44:57PM +0100, Christian Limpach wrote:
> On 7/10/06, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> >
> >On 7 Jul 2006, at 02:09, Horms wrote:
> >
> >> this is a resend of this patch, which I believe is a simple but
> >> useful feature. I have used it extensively to test the kdump
> >> patches which I have been developing with my colleague Magnus Damm.
> >> It is probably useful for other purposes too, and is analogous
> >> to the trigger crashdump feature of Linux's sysrq.
> >
> >On Linux the sysrq only does anything if kexec is in use and a crash
> >image has been provided (crash_kexec). Perhaps you should do the same
> >and make this part of the Xen portion of your kexec patches?
> 
> Also please use D (dump?) instead of p.  p is already used by the
> performance counters.
> 
> I'm a bit concerned that we might eventually run out of keys...  Is
> this really useful?

Its definately useful for testing, definately during development,
perhaps for production systems. I'll change it over to use D, incoporate
Keir's suggestion, and include it in the next kexec patches. 
It can always be axed if it prooves troublesome.

-- 
Horms                                           
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel