Re: [Xen-devel] [PATCH] Fix bug #709 by daemonizing blktapctrl and closing stdin, stdout and stderr

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 1 Aug 2006, at 11:06, Muli Ben-Yehuda wrote:

> > >  Also, fileno(stdin) is nicer.
> > Why? I don't think so.
> fclose(stdin); /* and the rest */
> fd = open(...); /* fd is 0 */
> close(STDIN_FILENO);  /* does the wrong thing */
> close(fileno(stdin)); /* does the right thing */
Yes, that's the better way even though we won't have done tricks such 
as the above when daemonise runs. Also a new patch needs to be based at 
least on xen-unstable 10876 which is the original patch from Harry -- 
it isn't in the public tree yet for some reason: I'll check up on that. 
And any changes may also need to be applied to the xenstored original 
(no sense in updating one and not the other).
 Cheers,
 Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel