RE: [Xen-devel] [PATCH] Minor fix to libxenstat to stop it returning NULL when domains go away at the wrong time

["Graham, Simon" <Simon.Graham@xxxxxxxxxxx>]

OK - final version (including a small bug fix over the last one) made
against the unstable tree

Simon

-----------------------------------------------------------
Currently, xenstat_get_node exits with a failure and returns NULL if a
VM is deleted 
between the time the list of VMs is obtained and the time it attempts to
collect 
information about the VMs. This patch modifies xenstat to ignore domains
that transition 
during the call.

Signed-off-by: Simon.Graham@xxxxxxxxxxx
-----------------------------------------------------------

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Keir Fraser
> Sent: Wednesday, August 02, 2006 5:20 AM
> To: Graham, Simon
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH] Minor fix to xentop to stop it
> dyingwhendomains go away at the wrong time
> 
> 
> On 28 Jul 2006, at 18:33, Graham, Simon wrote:
> 
> > Good suggestions - you are right that we only have issues when a VM
> is
> > in transition so simply removing it from the returned list should be
> > fine.
> >
> > Turns out that this also means the collectors don't need to return
> > special codes either - they are back to either working (and
> potentially
> > pruning a domain from the list) or failing completely.
> >
> > Patch attached (boy, this is taking waaay more time than I
expected!)
> 
> This looks good, but:
>   1. Needs to be against xen-unstable (doesn't apply right now, due to
> differences between unstable and testing trees)
>   2. Please provide an up-to-date checkin comment and signed-off-by
> line.
> 
> Fix these two issues and I'll check it straight in.
> 
>   Thanks,
>   Keir
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: xenstat-bug661.patch
Description: xenstat-bug661.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel